]> git.proxmox.com Git - mirror_kronosnet.git/commitdiff
[compress] don't leak memory in case of errors during zstd init
authorFabio M. Di Nitto <fdinitto@redhat.com>
Thu, 18 Jul 2019 11:12:36 +0000 (13:12 +0200)
committerFabio M. Di Nitto <fdinitto@redhat.com>
Tue, 23 Jul 2019 04:45:44 +0000 (06:45 +0200)
Signed-off-by: Fabio M. Di Nitto <fdinitto@redhat.com>
libknet/compress_zstd.c

index 8e679bb68c72d60aae0e5b0ae15df2d9d96b4b62..e460d27332d42232c08aa6f7bc1f605abf4afbb1 100644 (file)
@@ -72,6 +72,8 @@ static int zstd_init(
                }
                memset(zstd_ctx, 0, sizeof(struct zstd_ctx));
 
+               knet_h->compress_int_data[method_idx] = zstd_ctx;
+
                zstd_ctx->cctx = ZSTD_createCCtx();
                if (!zstd_ctx->cctx) {
                        log_err(knet_h, KNET_SUB_ZSTDCOMP, "Unable to create compression context");
@@ -85,8 +87,6 @@ static int zstd_init(
                        err = -1;
                        goto out_err;
                }
-
-               knet_h->compress_int_data[method_idx] = zstd_ctx;
        }
 
 out_err: