]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
net: decnet: dn_nsp_in: use swap macro in dn_nsp_rx_packet
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Sat, 28 Oct 2017 19:38:45 +0000 (14:38 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 1 Nov 2017 03:05:49 +0000 (12:05 +0900)
Make use of the swap macro and remove unnecessary variable tmp.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/decnet/dn_nsp_in.c

index 7ac086d5c0c017a54534a1a986fefd88e0bcb12f..1b2120645730577de9156215bee70c9a2b9e59e2 100644 (file)
@@ -776,12 +776,8 @@ static int dn_nsp_rx_packet(struct net *net, struct sock *sk2,
         * Swap src & dst and look up in the normal way.
         */
        if (unlikely(cb->rt_flags & DN_RT_F_RTS)) {
-               __le16 tmp = cb->dst_port;
-               cb->dst_port = cb->src_port;
-               cb->src_port = tmp;
-               tmp = cb->dst;
-               cb->dst = cb->src;
-               cb->src = tmp;
+               swap(cb->dst_port, cb->src_port);
+               swap(cb->dst, cb->src);
        }
 
        /*