]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
wifi: wl12xx: Drop if with an always false condition
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Fri, 15 Jul 2022 22:46:19 +0000 (00:46 +0200)
committerKalle Valo <kvalo@kernel.org>
Wed, 27 Jul 2022 12:51:53 +0000 (15:51 +0300)
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
(in wlcore_probe()) and so wl is never NULL.

This is a preparation for making platform remove callbacks return void.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/20220715224619.ht7bbzzrmysielm7@pengutronix.de
drivers/net/wireless/ti/wl12xx/main.c

index c6da0cfb4afbe7683856515871f092c652af17ec..d06a2c4194479a1cb99ce3d1333815347da0e98b 100644 (file)
@@ -1924,13 +1924,10 @@ static int wl12xx_remove(struct platform_device *pdev)
        struct wl1271 *wl = platform_get_drvdata(pdev);
        struct wl12xx_priv *priv;
 
-       if (!wl)
-               goto out;
        priv = wl->priv;
 
        kfree(priv->rx_mem_addr);
 
-out:
        return wlcore_remove(pdev);
 }