]> git.proxmox.com Git - proxmox-backup.git/commitdiff
ui: ds/content: disable some button for in-progress backup
authorThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 8 Jul 2020 10:21:56 +0000 (12:21 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Wed, 8 Jul 2020 10:22:00 +0000 (12:22 +0200)
We cannot verify, download, file-browse backups which are currently
in progress.

'Forget' could work but is probably not desirable?

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
www/DataStoreContent.js

index b6cce4623335c418f3e35bd37a2442e846b20a0f..70406b5c28a77fbc52f868137f056e6c2692a916 100644 (file)
@@ -402,12 +402,13 @@ Ext.define('PBS.DataStoreContent', {
            iconCls: 'fa fa-refresh',
            handler: 'reload',
        },
+       '-',
        {
            xtype: 'proxmoxButton',
            text: gettext('Verify'),
            disabled: true,
            parentXType: 'pbsDataStoreContent',
-           enableFn: function(record) { return !!record.data; },
+           enableFn: (rec) => !!rec.data && rec.data.size !== null,
            handler: 'onVerify',
        },
        {
@@ -415,7 +416,7 @@ Ext.define('PBS.DataStoreContent', {
            text: gettext('Prune'),
            disabled: true,
            parentXType: 'pbsDataStoreContent',
-           enableFn: function(record) { return !record.data.leaf; },
+           enableFn: (rec) => !rec.data.leaf,
            handler: 'onPrune',
        },
        {
@@ -424,24 +425,22 @@ Ext.define('PBS.DataStoreContent', {
            disabled: true,
            parentXType: 'pbsDataStoreContent',
            handler: 'onForget',
+           dangerous: true,
            confirmMsg: function(record) {
-               console.log(record);
+               //console.log(record);
                let name = record.data.text;
                return Ext.String.format(gettext('Are you sure you want to remove snapshot {0}'), `'${name}'`);
            },
-           enableFn: function(record) {
-               return !!record.data.leaf;
-           },
+           enableFn: (rec) => !!rec.data.leaf && rec.data.size !== null,
        },
+       '-',
        {
            xtype: 'proxmoxButton',
            text: gettext('Download Files'),
            disabled: true,
            parentXType: 'pbsDataStoreContent',
            handler: 'openBackupFileDownloader',
-           enableFn: function(record) {
-               return !!record.data.leaf;
-           },
+           enableFn: (rec) => !!rec.data.leaf && rec.data.size !== null,
        },
        {
            xtype: "proxmoxButton",
@@ -450,7 +449,7 @@ Ext.define('PBS.DataStoreContent', {
            handler: 'openPxarBrowser',
            parentXType: 'pbsDataStoreContent',
            enableFn: function(record) {
-               return !!record.data.leaf && record.data.files.some(el => el.filename.endsWith('pxar.didx'));
+               return !!record.data.leaf && record.size !== null && record.data.files.some(el => el.filename.endsWith('pxar.didx'));
            },
        }
     ],