]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
staging: android: ion: Remove check of debug_file
authorYisheng Xie <xieyisheng1@huawei.com>
Thu, 22 Feb 2018 10:58:39 +0000 (18:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 22 Feb 2018 13:53:05 +0000 (14:53 +0100)
There's no need to check the return value of debug_file for it is just a
debugfs and we will go on the following process if we failed to create
debug_file. So just remove it.

Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ion/ion.c

index 74d9a4e29b2b6d44b2e379f5fcb57d33d202f307..0606d50c32d978100b626a1a0830efe4120a2efc 100644 (file)
@@ -522,7 +522,6 @@ DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
 
 void ion_device_add_heap(struct ion_heap *heap)
 {
-       struct dentry *debug_file;
        struct ion_device *dev = internal_dev;
        int ret;
 
@@ -556,12 +555,8 @@ void ion_device_add_heap(struct ion_heap *heap)
                char debug_name[64];
 
                snprintf(debug_name, 64, "%s_shrink", heap->name);
-               debug_file = debugfs_create_file(debug_name,
-                                                0644, dev->debug_root, heap,
-                                                &debug_shrink_fops);
-               if (!debug_file)
-                       pr_err("Failed to create ion heap shrinker debugfs at %s\n",
-                              debug_name);
+               debugfs_create_file(debug_name, 0644, dev->debug_root,
+                                   heap, &debug_shrink_fops);
        }
 
        dev->heap_cnt++;