]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
Btrfs: ratelimit the generation printk for the free space cache
authorJosef Bacik <josef@redhat.com>
Mon, 8 Aug 2011 12:24:46 +0000 (08:24 -0400)
committerJosef Bacik <josef@redhat.com>
Wed, 19 Oct 2011 19:12:33 +0000 (15:12 -0400)
A user reported getting spammed when moving to 3.0 by this message.  Since we
switched to the normal checksumming infrastructure all old free space caches
will be wrong and need to be regenerated so people are likely to see this
message a lot, so ratelimit it so it doesn't fill up their logs and freak them
out.  Thanks,

Reported-by: Andrew Lutomirski <luto@mit.edu>
Signed-off-by: Josef Bacik <josef@redhat.com>
fs/btrfs/free-space-cache.c

index 79c16a68a2bcec8d8d1368833a80c88dda48aea8..ecc1a4f85d20f9037f96b29f4bf38bdcd4bb3611 100644 (file)
@@ -20,6 +20,7 @@
 #include <linux/sched.h>
 #include <linux/slab.h>
 #include <linux/math64.h>
+#include <linux/ratelimit.h>
 #include "ctree.h"
 #include "free-space-cache.h"
 #include "transaction.h"
@@ -341,11 +342,12 @@ int __load_free_space_cache(struct btrfs_root *root, struct inode *inode,
 
                        gen = addr;
                        if (*gen != BTRFS_I(inode)->generation) {
-                               printk(KERN_ERR "btrfs: space cache generation"
-                                      " (%llu) does not match inode (%llu)\n",
-                                      (unsigned long long)*gen,
-                                      (unsigned long long)
-                                      BTRFS_I(inode)->generation);
+                               printk_ratelimited(KERN_ERR "btrfs: space cache"
+                                       " generation (%llu) does not match "
+                                       "inode (%llu)\n",
+                                       (unsigned long long)*gen,
+                                       (unsigned long long)
+                                       BTRFS_I(inode)->generation);
                                kunmap(page);
                                unlock_page(page);
                                page_cache_release(page);