refdb: bubble up recursive rm when locking a ref

Failure to bubble up this error means some locking errors do not get reported as
such on Windows.

diff --git a/src/refdb_fs.c b/src/refdb_fs.c
index 558d06094f2c3345878b170ebd4969d3caef0e9e..8739d5b89d559bef385e3c3fd8df33c05fa49945 100644 (file)
--- a/src/refdb_fs.c
+++ b/src/refdb_fs.c
@@ -729,8 +729,8 @@ static int loose_lock(git_filebuf *file, refdb_fs_backend *backend, const char *
        /* Remove a possibly existing empty directory hierarchy
         * which name would collide with the reference name
         */
-       if (git_futils_rmdir_r(name, backend->path, GIT_RMDIR_SKIP_NONEMPTY) < 0)
-               return -1;
+       if ((error = git_futils_rmdir_r(name, backend->path, GIT_RMDIR_SKIP_NONEMPTY)) < 0)
+               return error;
 
        if (git_buf_joinpath(&ref_path, backend->path, name) < 0)
                return -1;