]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
mailbox: arm-mhu: Use device-managed registration API
authorThierry Reding <treding@nvidia.com>
Thu, 20 Dec 2018 17:19:45 +0000 (18:19 +0100)
committerJassi Brar <jaswinder.singh@linaro.org>
Fri, 21 Dec 2018 22:49:25 +0000 (16:49 -0600)
Get rid of some boilerplate driver removal code by using the newly added
device-managed registration API.

Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
drivers/mailbox/arm_mhu.c

index 99befa76e37c70d70d7f89b0db0c7aa6e1a24701..64d85c6a2bdfa8af4e9a53fa85ca39675ff0e943 100644 (file)
@@ -152,7 +152,7 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
 
        amba_set_drvdata(adev, mhu);
 
-       err = mbox_controller_register(&mhu->mbox);
+       err = devm_mbox_controller_register(dev, &mhu->mbox);
        if (err) {
                dev_err(dev, "Failed to register mailboxes %d\n", err);
                return err;
@@ -162,15 +162,6 @@ static int mhu_probe(struct amba_device *adev, const struct amba_id *id)
        return 0;
 }
 
-static int mhu_remove(struct amba_device *adev)
-{
-       struct arm_mhu *mhu = amba_get_drvdata(adev);
-
-       mbox_controller_unregister(&mhu->mbox);
-
-       return 0;
-}
-
 static struct amba_id mhu_ids[] = {
        {
                .id     = 0x1bb098,
@@ -186,7 +177,6 @@ static struct amba_driver arm_mhu_driver = {
        },
        .id_table       = mhu_ids,
        .probe          = mhu_probe,
-       .remove         = mhu_remove,
 };
 module_amba_driver(arm_mhu_driver);