]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
ALSA: hda/realtek: Fix bass speaker DAC mapping for Asus UM431D
authorTakashi Iwai <tiwai@suse.de>
Sun, 20 Jun 2021 06:59:52 +0000 (08:59 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 13 Aug 2021 07:29:38 +0000 (09:29 +0200)
BugLink: https://bugs.launchpad.net/bugs/1938340
commit f8fbcdfb0665de60997d9746809e1704ed782bbc upstream.

Asus Zenbook 14 UM431D has two speaker pins and a headphone pin, and
the auto-parser ends up assigning the bass to the third DAC 0x06.
Although the tone comes out, it's inconvenient because this DAC has no
volume control unlike two other DACs.

For obtaining the volume control for the bass speaker, this patch
enforces the mapping to let both front and bass speaker pins sharing
the same DAC.  It's not ideal but a little bit of improvement.

Since we've already applied the same workaround for another ASUS
machine, we just need to hook the chain to the existing quirk.

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212547
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210620065952.18948-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sound/pci/hda/patch_realtek.c

index 50da3106ee450f8446c5d7e6c4054d1dab782352..418b7c1fb68ef8902212c8ffcb5bfb03f8fdfed0 100644 (file)
@@ -7832,6 +7832,8 @@ static const struct hda_fixup alc269_fixups[] = {
                        { 0x20, AC_VERB_SET_PROC_COEF, 0x4e4b },
                        { }
                },
+               .chained = true,
+               .chain_id = ALC289_FIXUP_ASUS_GA401,
        },
        [ALC285_FIXUP_HP_GPIO_LED] = {
                .type = HDA_FIXUP_FUNC,