]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
Input: retu-pwrbutton - pass the IRQF_ONESHOT flag
authorFabio Estevam <fabio.estevam@freescale.com>
Fri, 15 May 2015 22:55:34 +0000 (15:55 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 15 May 2015 22:58:41 +0000 (15:58 -0700)
Since commit 1c6c69525b40eb76de8adf039409722015927dc3 ("genirq: Reject
bogus threaded irq requests") threaded IRQs without a primary handler
need to be requested with IRQF_ONESHOT, otherwise the request will fail.

So pass the IRQF_ONESHOT flag in this case.

The semantic patch that makes this change is available
in scripts/coccinelle/misc/irqf_oneshot.cocci.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/retu-pwrbutton.c

index 0c8ac60e2639d71ea618eb5913f8eed8235c6f90..30b459b6b344c427cd4bef9501b4c592ef952a56 100644 (file)
@@ -63,7 +63,8 @@ static int retu_pwrbutton_probe(struct platform_device *pdev)
        input_set_drvdata(idev, rdev);
 
        error = devm_request_threaded_irq(&pdev->dev, irq,
-                                         NULL, retu_pwrbutton_irq, 0,
+                                         NULL, retu_pwrbutton_irq,
+                                         IRQF_ONESHOT,
                                          "retu-pwrbutton", idev);
        if (error)
                return error;