]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
x86: vdso: Remove bogus locking in update_vsyscall_tz()
authorThomas Gleixner <tglx@linutronix.de>
Tue, 28 Feb 2012 19:46:04 +0000 (19:46 +0000)
committerJohn Stultz <john.stultz@linaro.org>
Fri, 16 Mar 2012 01:17:57 +0000 (18:17 -0700)
Changing the sequence count in update_vsyscall_tz() is completely
pointless.

The vdso code copies the data unprotected. There is no point to change
this as sys_tz is nowhere protected at all. See sys_gettimeofday().

Reviewed-by: Andy Lutomirski <luto@amacapital.net>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
arch/x86/kernel/vsyscall_64.c

index b07ba9393564ddce2413cbc07e8fec27f47fa9c9..33385c18e5d319d8cb81216411dfdbcc611a65d9 100644 (file)
@@ -80,12 +80,7 @@ early_param("vsyscall", vsyscall_setup);
 
 void update_vsyscall_tz(void)
 {
-       unsigned long flags;
-
-       write_seqlock_irqsave(&vsyscall_gtod_data.lock, flags);
-       /* sys_tz has changed */
        vsyscall_gtod_data.sys_tz = sys_tz;
-       write_sequnlock_irqrestore(&vsyscall_gtod_data.lock, flags);
 }
 
 void update_vsyscall(struct timespec *wall_time, struct timespec *wtm,