]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: hns3: Fix for command format parsing error in hclge_is_all_function_id_zero
authorXi Wang <wangxi11@huawei.com>
Tue, 14 Aug 2018 16:13:13 +0000 (17:13 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Aug 2018 16:54:23 +0000 (09:54 -0700)
According to the functional specification of hardware, the first
descriptor of response from command 'lookup vlan talbe' is not valid.
Currently, the first descriptor is parsed as normal value, which will
cause an expected error.

This patch fixes this problem by skipping the first descriptor.

Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support")
Signed-off-by: Xi Wang <wangxi11@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

index 92091221202b26fb004bfd3f1c00d6b9ebb2358b..5f30ea4c51427f1c8eb6f0f5ce673fc4b125793c 100644 (file)
@@ -3930,7 +3930,7 @@ static bool hclge_is_all_function_id_zero(struct hclge_desc *desc)
 #define HCLGE_FUNC_NUMBER_PER_DESC 6
        int i, j;
 
-       for (i = 0; i < HCLGE_DESC_NUMBER; i++)
+       for (i = 1; i < HCLGE_DESC_NUMBER; i++)
                for (j = 0; j < HCLGE_FUNC_NUMBER_PER_DESC; j++)
                        if (desc[i].data[j])
                                return false;