]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
ca8210: fix mac_len negative array access
authorAlexander Aring <aahringo@redhat.com>
Fri, 17 Feb 2023 04:25:04 +0000 (23:25 -0500)
committerStefan Schmidt <stefan@datenfreihafen.org>
Thu, 2 Mar 2023 13:39:48 +0000 (14:39 +0100)
This patch fixes a buffer overflow access of skb->data if
ieee802154_hdr_peek_addrs() fails.

Reported-by: lianhui tang <bluetlh@gmail.com>
Signed-off-by: Alexander Aring <aahringo@redhat.com>
Link: https://lore.kernel.org/r/20230217042504.3303396-1-aahringo@redhat.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
drivers/net/ieee802154/ca8210.c

index e1a569b99e4a6a071acf0488070298134bd40aab..0b0c6c0764fe9cfab3247917f16a6cb6be93f06e 100644 (file)
@@ -1913,6 +1913,8 @@ static int ca8210_skb_tx(
         * packet
         */
        mac_len = ieee802154_hdr_peek_addrs(skb, &header);
+       if (mac_len < 0)
+               return mac_len;
 
        secspec.security_level = header.sec.level;
        secspec.key_id_mode = header.sec.key_id_mode;