]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
treewide: Use DEVICE_ATTR_WO
authorJoe Perches <joe@perches.com>
Tue, 19 Dec 2017 18:15:09 +0000 (10:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Jan 2018 15:34:35 +0000 (16:34 +0100)
Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible.

Done with perl script:

$ git grep -w --name-only DEVICE_ATTR | \
  xargs perl -i -e 'local $/; while (<>) { s/\bDEVICE_ATTR\s*\(\s*(\w+)\s*,\s*\(?(?:\s*S_IWUSR\s*|\s*0200\s*)\)?\s*,\s*NULL\s*,\s*\s_store\s*\)/DEVICE_ATTR_WO(\1)/g; print;}'

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/s390/kernel/smp.c
arch/x86/kernel/cpu/microcode/core.c
drivers/input/touchscreen/elants_i2c.c
drivers/net/ethernet/ibm/ibmvnic.c
drivers/net/wimax/i2400m/sysfs.c
drivers/scsi/lpfc/lpfc_attr.c
drivers/thermal/thermal_sysfs.c

index b8c1a85bcf2de75eccba0b5b86eb2870bd4b71b6..a919b2f0141da3be91cbdda76afe106a594e489b 100644 (file)
@@ -1151,7 +1151,7 @@ static ssize_t __ref rescan_store(struct device *dev,
        rc = smp_rescan_cpus();
        return rc ? rc : count;
 }
-static DEVICE_ATTR(rescan, 0200, NULL, rescan_store);
+static DEVICE_ATTR_WO(rescan);
 #endif /* CONFIG_HOTPLUG_CPU */
 
 static int __init s390_smp_init(void)
index c4fa4a85d4cb6f4e0cb4b34cd20467879167463d..09c74b0560dd7b5f5d83c099032039bfac330147 100644 (file)
@@ -560,7 +560,7 @@ static ssize_t pf_show(struct device *dev,
        return sprintf(buf, "0x%x\n", uci->cpu_sig.pf);
 }
 
-static DEVICE_ATTR(reload, 0200, NULL, reload_store);
+static DEVICE_ATTR_WO(reload);
 static DEVICE_ATTR(version, 0400, version_show, NULL);
 static DEVICE_ATTR(processor_flags, 0400, pf_show, NULL);
 
index e102d7764bc25e50649e34e229afda59552dfe8b..98613910d75657061b3e062a3410dccf32d61e21 100644 (file)
@@ -999,7 +999,7 @@ static ssize_t show_iap_mode(struct device *dev,
                                "Normal" : "Recovery");
 }
 
-static DEVICE_ATTR(calibrate, S_IWUSR, NULL, calibrate_store);
+static DEVICE_ATTR_WO(calibrate);
 static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL);
 static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw);
 
index 1dc4aef37d3a4faf3592ab0dede92b802a831824..42b96e1a1b131e716355d0e041080b87fe039eee 100644 (file)
@@ -4411,7 +4411,7 @@ static ssize_t failover_store(struct device *dev, struct device_attribute *attr,
        return count;
 }
 
-static DEVICE_ATTR(failover, 0200, NULL, failover_store);
+static DEVICE_ATTR_WO(failover);
 
 static unsigned long ibmvnic_get_desired_dma(struct vio_dev *vdev)
 {
index 1237109f251abf103434ebfaa53740750b6cd65e..8c67df11105ca74c764be0b0a4d25a472644a732 100644 (file)
@@ -65,8 +65,7 @@ error_bad_value:
 }
 
 static
-DEVICE_ATTR(i2400m_idle_timeout, S_IWUSR,
-           NULL, i2400m_idle_timeout_store);
+DEVICE_ATTR_WO(i2400m_idle_timeout);
 
 static
 struct attribute *i2400m_dev_attrs[] = {
index ea8d382bc2eb059099ec1873c083e2028387a35b..a28618c3eb635d7115610ebeeefdf2858ec2a8be 100644 (file)
@@ -2384,8 +2384,7 @@ lpfc_soft_wwn_enable_store(struct device *dev, struct device_attribute *attr,
 
        return count;
 }
-static DEVICE_ATTR(lpfc_soft_wwn_enable, S_IWUSR, NULL,
-                  lpfc_soft_wwn_enable_store);
+static DEVICE_ATTR_WO(lpfc_soft_wwn_enable);
 
 /**
  * lpfc_soft_wwpn_show - Return the cfg soft ww port name of the adapter
index 2bc964392924747b0cec220c613b746f70bd7b73..ba81c9080f6ecadd123ce70e5a1cccc8e6e0a8a2 100644 (file)
@@ -317,7 +317,7 @@ emul_temp_store(struct device *dev, struct device_attribute *attr,
 
        return ret ? ret : count;
 }
-static DEVICE_ATTR(emul_temp, S_IWUSR, NULL, emul_temp_store);
+static DEVICE_ATTR_WO(emul_temp);
 #endif
 
 static ssize_t