net/mlx5: potential error pointer dereference in error handling

The error handling was a bit flipped around.  If the mlx5_create_flow_group()
function failed then it would have resulted in dereferencing "fg" when
it was an error pointer.

Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c
index 86f77456f873484742b2efef9919611f2fcf5f96..401441aefbcbc3b885a458c590c18f72a422b60b 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlx5/core/rdma.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/rdma.c
@@ -106,10 +106,10 @@ static int mlx5_rdma_enable_roce_steering(struct mlx5_core_dev *dev)
 
        return 0;
 
-destroy_flow_table:
-       mlx5_destroy_flow_table(ft);
 destroy_flow_group:
        mlx5_destroy_flow_group(fg);
+destroy_flow_table:
+       mlx5_destroy_flow_table(ft);
 free:
        kvfree(spec);
        kvfree(flow_group_in);