zebra: fix SA warning, don't lock plugin list

Locking around the list of providers/plugins is not
helpful - these only change at init time. Clear some SA
warnings by removing the locking.

Signed-off-by: Mark Stapp <mjs@labn.net>

diff --git a/zebra/zebra_dplane.c b/zebra/zebra_dplane.c
index 7db8fba95bfea3d5f06fb3e155e37ddf4b10aa7a..ef4cef65ca55c59bd0da228add6c623c4f7962db 100644 (file)
--- a/zebra/zebra_dplane.c
+++ b/zebra/zebra_dplane.c
@@ -5551,9 +5551,7 @@ int dplane_show_provs_helper(struct vty *vty, bool detailed)
                        prov->dp_name, prov->dp_id, in, in_q, in_max,
                        out, out_q, out_max);
 
-               DPLANE_LOCK();
                prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov);
-               DPLANE_UNLOCK();
        }
 
        return CMD_SUCCESS;
@@ -6592,9 +6590,7 @@ static bool dplane_work_pending(void)
                if (ctx != NULL)
                        break;
 
-               DPLANE_LOCK();
                prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov);
-               DPLANE_UNLOCK();
        }
 
        if (ctx != NULL)
@@ -6822,9 +6818,7 @@ static void dplane_thread_loop(struct thread *event)
                                   counter, dplane_provider_get_name(prov));
 
                /* Locate next provider */
-               DPLANE_LOCK();
                prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov);
-               DPLANE_UNLOCK();
        }
 
        /*
@@ -6968,9 +6962,7 @@ void zebra_dplane_start(void)
                        (prov->dp_start)(prov);
 
                /* Locate next provider */
-               DPLANE_LOCK();
                prov = dplane_prov_list_next(&zdplane_info.dg_providers, prov);
-               DPLANE_UNLOCK();
        }
 
        frr_pthread_run(zdplane_info.dg_pthread, NULL);