]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
Bluetooth: Prevent out-of-bounds read in hci_inquiry_result_evt()
authorPeilin Ye <yepeilin.cs@gmail.com>
Fri, 10 Jul 2020 21:39:18 +0000 (17:39 -0400)
committerThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Fri, 4 Sep 2020 19:28:42 +0000 (16:28 -0300)
BugLink: https://bugs.launchpad.net/bugs/1891387
commit 75bbd2ea50ba1c5d9da878a17e92eac02fe0fd3a upstream.

Check `num_rsp` before using it as for-loop counter.

Cc: stable@vger.kernel.org
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Ian May <ian.may@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
net/bluetooth/hci_event.c

index c7e4496b243e7606b5321c47dfa9b387923168f1..33c3c5b0fef0e3b8121812ecc753a40c2ab8fb19 100644 (file)
@@ -2444,7 +2444,7 @@ static void hci_inquiry_result_evt(struct hci_dev *hdev, struct sk_buff *skb)
 
        BT_DBG("%s num_rsp %d", hdev->name, num_rsp);
 
-       if (!num_rsp)
+       if (!num_rsp || skb->len < num_rsp * sizeof(*info) + 1)
                return;
 
        if (hci_dev_test_flag(hdev, HCI_PERIODIC_INQ))