]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: phy: Stop with excessive soft reset
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 25 Sep 2018 18:28:45 +0000 (11:28 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 26 Sep 2018 03:26:45 +0000 (20:26 -0700)
While consolidating the PHY reset in phy_init_hw() an unconditionaly
BMCR soft-reset I became quite trigger happy with those. This was later
on deactivated for the Generic PHY driver on the premise that a prior
software entity (e.g: bootloader) might have applied workarounds in
commit 0878fff1f42c ("net: phy: Do not perform software reset for
Generic PHY").

Since we have a hook to wire-up a soft_reset callback, just use that and
get rid of the call to genphy_soft_reset() entirely. This speeds up
initialization and link establishment for most PHYs out there that do
not require a reset.

Fixes: 87aa9f9c61ad ("net: phy: consolidate PHY reset in phy_init_hw()")
Tested-by: Wang, Dongsheng <dongsheng.wang@hxt-semitech.com>
Tested-by: Chris Healy <cphealy@gmail.com>
Tested-by: Andrew Lunn <andrew@lunn.ch>
Tested-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy_device.c

index af64a9320fb084d28d4703d3f4389f9b808be47a..ee676d75fe02c1afd9cb6573307afd4709f041f3 100644 (file)
@@ -880,8 +880,6 @@ int phy_init_hw(struct phy_device *phydev)
 
        if (phydev->drv->soft_reset)
                ret = phydev->drv->soft_reset(phydev);
-       else
-               ret = genphy_soft_reset(phydev);
 
        if (ret < 0)
                return ret;