]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
gpio: gpio-xilinx: Fix integer overflow
authorSrinivas Neeli <srinivas.neeli@xilinx.com>
Thu, 21 Jul 2022 07:39:09 +0000 (13:09 +0530)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 16 Sep 2022 08:53:26 +0000 (10:53 +0200)
BugLink: https://bugs.launchpad.net/bugs/1988479
[ Upstream commit 32c094a09d5829ad9b02cdf667569aefa8de0ea6 ]

Current implementation is not able to configure more than 32 pins
due to incorrect data type. So type casting with unsigned long
to avoid it.

Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")
Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
drivers/gpio/gpio-xilinx.c

index a1b66338d077dae678ba27f6d6e6fd88e3d59116..db616ae560a3cab8eb57f735f73c2109cf5254a0 100644 (file)
@@ -99,7 +99,7 @@ static inline void xgpio_set_value32(unsigned long *map, int bit, u32 v)
        const unsigned long offset = (bit % BITS_PER_LONG) & BIT(5);
 
        map[index] &= ~(0xFFFFFFFFul << offset);
-       map[index] |= v << offset;
+       map[index] |= (unsigned long)v << offset;
 }
 
 static inline int xgpio_regoffset(struct xgpio_instance *chip, int ch)