]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
usb: hso: remove the bailout parameter
authorDongliang Mu <mudongliangabcd@gmail.com>
Wed, 21 Jul 2021 08:14:57 +0000 (16:14 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 5 Nov 2021 08:12:51 +0000 (09:12 +0100)
BugLink: https://bugs.launchpad.net/bugs/1947888
commit dcb713d53e2eadf42b878c12a471e74dc6ed3145 upstream.

There are two invocation sites of hso_free_net_device. After
refactoring hso_create_net_device, this parameter is useless.
Remove the bailout in the hso_free_net_device and change the invocation
sites of this function.

Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ovidiu Panait <ovidiu.panait@windriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
drivers/net/usb/hso.c

index 41b2724e7ce39af4db3b684928d2e39d736fe905..31200275a0640ae7e44a66db7d80e5e61db2c312 100644 (file)
@@ -2354,7 +2354,7 @@ static int remove_net_device(struct hso_device *hso_dev)
 }
 
 /* Frees our network device */
-static void hso_free_net_device(struct hso_device *hso_dev, bool bailout)
+static void hso_free_net_device(struct hso_device *hso_dev)
 {
        int i;
        struct hso_net *hso_net = dev2net(hso_dev);
@@ -2377,7 +2377,7 @@ static void hso_free_net_device(struct hso_device *hso_dev, bool bailout)
        kfree(hso_net->mux_bulk_tx_buf);
        hso_net->mux_bulk_tx_buf = NULL;
 
-       if (hso_net->net && !bailout)
+       if (hso_net->net)
                free_netdev(hso_net->net);
 
        kfree(hso_dev);
@@ -3133,7 +3133,7 @@ static void hso_free_interface(struct usb_interface *interface)
                                rfkill_unregister(rfk);
                                rfkill_destroy(rfk);
                        }
-                       hso_free_net_device(network_table[i], false);
+                       hso_free_net_device(network_table[i]);
                }
        }
 }