thunderbolt: Hide authorized attribute if router does not support PCIe tunnels

With USB4 devices PCIe tunneling is optional so for device routers
without PCIe upstream adapter it does not make much sense to expose the
authorized attribute. For this reason hide it if PCIe tunneling is not
supported by the device router.

Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/thunderbolt/switch.c b/drivers/thunderbolt/switch.c
index a1b4a695080e35ffc7cc63cc5b788733d04acdcd..fbcc920e327c0c6a01d899121b040aa26e391388 100644 (file)
--- a/drivers/thunderbolt/switch.c
+++ b/drivers/thunderbolt/switch.c
@@ -1746,6 +1746,18 @@ static struct attribute *switch_attrs[] = {
        NULL,
 };
 
+static bool has_port(const struct tb_switch *sw, enum tb_port_type type)
+{
+       const struct tb_port *port;
+
+       tb_switch_for_each_port(sw, port) {
+               if (!port->disabled && port->config.type == type)
+                       return true;
+       }
+
+       return false;
+}
+
 static umode_t switch_attr_is_visible(struct kobject *kobj,
                                      struct attribute *attr, int n)
 {
@@ -1754,7 +1766,8 @@ static umode_t switch_attr_is_visible(struct kobject *kobj,
 
        if (attr == &dev_attr_authorized.attr) {
                if (sw->tb->security_level == TB_SECURITY_NOPCIE ||
-                   sw->tb->security_level == TB_SECURITY_DPONLY)
+                   sw->tb->security_level == TB_SECURITY_DPONLY ||
+                   !has_port(sw, TB_TYPE_PCIE_UP))
                        return 0;
        } else if (attr == &dev_attr_device.attr) {
                if (!sw->device)