]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
qed: remove pointless call to devlink_param_driverinit_value_set()
authorJiri Pirko <jiri@nvidia.com>
Thu, 26 Jan 2023 07:58:32 +0000 (08:58 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jan 2023 12:32:02 +0000 (12:32 +0000)
devlink_param_driverinit_value_set() call makes sense only for "
driverinit" params. However here, the param is "runtime".
devlink_param_driverinit_value_set() returns -EOPNOTSUPP in such case
and does not do anything. So remove the pointless call to
devlink_param_driverinit_value_set() entirely.

Signed-off-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_devlink.c

index 922c47797af6a7de862b9be839437b3ed3d92189..be5cc8b79bd510c1cee3e817d768f24f1097ced3 100644 (file)
@@ -198,7 +198,6 @@ static const struct devlink_ops qed_dl_ops = {
 
 struct devlink *qed_devlink_register(struct qed_dev *cdev)
 {
-       union devlink_param_value value;
        struct qed_devlink *qdevlink;
        struct devlink *dl;
        int rc;
@@ -216,11 +215,6 @@ struct devlink *qed_devlink_register(struct qed_dev *cdev)
        if (rc)
                goto err_unregister;
 
-       value.vbool = false;
-       devlink_param_driverinit_value_set(dl,
-                                          QED_DEVLINK_PARAM_ID_IWARP_CMT,
-                                          value);
-
        cdev->iwarp_cmt = false;
 
        qed_fw_reporters_create(dl);