]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
gpio: acpi: Synchronize acpi_find_gpio() and acpi_gpio_count()
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 23 May 2017 17:03:20 +0000 (20:03 +0300)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 29 May 2017 09:18:44 +0000 (11:18 +0200)
If we pass connection ID to the both functions and at the same time
acpi_can_fallback_to_crs() returns false we will get different results,
i.e. the number of GPIO resources returned by acpi_gpio_count() might be
not correct.

Fix this by calling acpi_can_fallback_to_crs() in acpi_gpio_count()
before trying to fallback.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpiolib-acpi.c

index 0392d8ed332f0ad0194e7e112894e10f3997accc..740df0e9dcb3d7ec6dbf99a4d9f3560fe4548eab 100644 (file)
@@ -1119,6 +1119,9 @@ int acpi_gpio_count(struct device *dev, const char *con_id)
                struct list_head resource_list;
                unsigned int crs_count = 0;
 
+               if (!acpi_can_fallback_to_crs(adev, con_id))
+                       return count;
+
                INIT_LIST_HEAD(&resource_list);
                acpi_dev_get_resources(adev, &resource_list,
                                       acpi_find_gpio_count, &crs_count);