RDMA/rtrs-clt: Refactor the failure cases in alloc_clt

[ Upstream commit eab098246625e91c1cbd6e8f75b09e4c9c28a9fc ]

Make all failure cases go to the common path to avoid duplicate code.
And some issued existed before.

1. clt need to be freed to avoid memory leak.

2. return ERR_PTR(-ENOMEM) if kobject_create_and_add fails, because
   rtrs_clt_open checks the return value of by call "IS_ERR(clt)".

Fixes: 6a98d71daea1 ("RDMA/rtrs: client: main functionality")
Link: https://lore.kernel.org/r/20201217141915.56989-15-jinpu.wang@cloud.ionos.com
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Reviewed-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index b3fb5fb93815fca574899a044ab738b9e9eaf412..172bf7f221ff029dae25a8bb54ffedd947ed88e9 100644 (file)
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -2570,11 +2570,8 @@ static struct rtrs_clt *alloc_clt(const char *sessname, size_t paths_num,
        clt->dev.class = rtrs_clt_dev_class;
        clt->dev.release = rtrs_clt_dev_release;
        err = dev_set_name(&clt->dev, "%s", sessname);
-       if (err) {
-               free_percpu(clt->pcpu_path);
-               kfree(clt);
-               return ERR_PTR(err);
-       }
+       if (err)
+               goto err;
        /*
         * Suppress user space notification until
         * sysfs files are created
@@ -2582,29 +2579,31 @@ static struct rtrs_clt *alloc_clt(const char *sessname, size_t paths_num,
        dev_set_uevent_suppress(&clt->dev, true);
        err = device_register(&clt->dev);
        if (err) {
-               free_percpu(clt->pcpu_path);
                put_device(&clt->dev);
-               return ERR_PTR(err);
+               goto err;
        }
 
        clt->kobj_paths = kobject_create_and_add("paths", &clt->dev.kobj);
        if (!clt->kobj_paths) {
-               free_percpu(clt->pcpu_path);
-               device_unregister(&clt->dev);
-               return NULL;
+               err = -ENOMEM;
+               goto err_dev;
        }
        err = rtrs_clt_create_sysfs_root_files(clt);
        if (err) {
-               free_percpu(clt->pcpu_path);
                kobject_del(clt->kobj_paths);
                kobject_put(clt->kobj_paths);
-               device_unregister(&clt->dev);
-               return ERR_PTR(err);
+               goto err_dev;
        }
        dev_set_uevent_suppress(&clt->dev, false);
        kobject_uevent(&clt->dev.kobj, KOBJ_ADD);
 
        return clt;
+err_dev:
+       device_unregister(&clt->dev);
+err:
+       free_percpu(clt->pcpu_path);
+       kfree(clt);
+       return ERR_PTR(err);
 }
 
 static void wait_for_inflight_permits(struct rtrs_clt *clt)