]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
perf tracepoint: Fix memory leak in is_valid_tracepoint()
authorYang Jihong <yangjihong1@huawei.com>
Fri, 21 Apr 2023 02:59:53 +0000 (02:59 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 9 Aug 2023 09:37:43 +0000 (11:37 +0200)
BugLink: https://bugs.launchpad.net/bugs/2028580
[ Upstream commit 9b86c49710eec7b4fbb78a0232b2dd0972a2b576 ]

When is_valid_tracepoint() returns 1, need to call put_events_file() to
free `dir_path`.

Fixes: 25a7d914274de386 ("perf parse-events: Use get/put_events_file()")
Signed-off-by: Yang Jihong <yangjihong1@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20230421025953.173826-1-yangjihong1@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/perf/util/tracepoint.c

index 89ef56c433110e2f0f195252f8d9a0414a6d3519..92dd8b455b9026aeb7126f186f8b74f8bd4bb162 100644 (file)
@@ -50,6 +50,7 @@ int is_valid_tracepoint(const char *event_string)
                                 sys_dirent->d_name, evt_dirent->d_name);
                        if (!strcmp(evt_path, event_string)) {
                                closedir(evt_dir);
+                               put_events_file(dir_path);
                                closedir(sys_dir);
                                return 1;
                        }