]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
scsi: aic7xxx: Fix error code handling
authorTong Zhang <ztong0001@gmail.com>
Sun, 16 Aug 2020 07:02:42 +0000 (03:02 -0400)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 25 Aug 2020 03:13:27 +0000 (23:13 -0400)
ahc_linux_queue_recovery_cmd returns SUCCESS(0x2002) or FAIL(0x2003), but
the caller is checking error case using != 0.

Link: https://lore.kernel.org/r/20200816070242.978839-1-ztong0001@gmail.com
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/aic7xxx/aic7xxx_osm.c

index e7ccb8b80fc190adee9dcf4c7bb24cee1d7e175a..7bba961d1ae0aafaed02eb4965dd04c7d5eb3b1a 100644 (file)
@@ -730,7 +730,7 @@ ahc_linux_abort(struct scsi_cmnd *cmd)
        int error;
 
        error = ahc_linux_queue_recovery_cmd(cmd, SCB_ABORT);
-       if (error != 0)
+       if (error != SUCCESS)
                printk("aic7xxx_abort returns 0x%x\n", error);
        return (error);
 }
@@ -744,7 +744,7 @@ ahc_linux_dev_reset(struct scsi_cmnd *cmd)
        int error;
 
        error = ahc_linux_queue_recovery_cmd(cmd, SCB_DEVICE_RESET);
-       if (error != 0)
+       if (error != SUCCESS)
                printk("aic7xxx_dev_reset returns 0x%x\n", error);
        return (error);
 }