]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
qede: Add missing Status-block free
authorSudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Sun, 21 May 2017 09:10:54 +0000 (12:10 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 21 May 2017 16:56:53 +0000 (12:56 -0400)
When destroying the datapath channels, qede doesn't notify qed of the
released status blocks which were acquired during the initialization.

Signed-off-by: Sudarsana Reddy Kalluru <Sudarsana.Kalluru@cavium.com>
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_main.c

index 766bd373fa99d26f89c88120513d87390d51e294..aea9dcfae62a56fd33dcf308e9c6305490eeea23 100644 (file)
@@ -1072,12 +1072,15 @@ static int qede_set_num_queues(struct qede_dev *edev)
        return rc;
 }
 
-static void qede_free_mem_sb(struct qede_dev *edev,
-                            struct qed_sb_info *sb_info)
+static void qede_free_mem_sb(struct qede_dev *edev, struct qed_sb_info *sb_info,
+                            u16 sb_id)
 {
-       if (sb_info->sb_virt)
+       if (sb_info->sb_virt) {
+               edev->ops->common->sb_release(edev->cdev, sb_info, sb_id);
                dma_free_coherent(&edev->pdev->dev, sizeof(*sb_info->sb_virt),
                                  (void *)sb_info->sb_virt, sb_info->sb_phys);
+               memset(sb_info, 0, sizeof(*sb_info));
+       }
 }
 
 /* This function allocates fast-path status block memory */
@@ -1334,7 +1337,7 @@ err:
 /* This function frees all memory of a single fp */
 static void qede_free_mem_fp(struct qede_dev *edev, struct qede_fastpath *fp)
 {
-       qede_free_mem_sb(edev, fp->sb_info);
+       qede_free_mem_sb(edev, fp->sb_info, fp->id);
 
        if (fp->type & QEDE_FASTPATH_RX)
                qede_free_mem_rxq(edev, fp->rxq);