]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
scsi: zfcp: update kernel message for invalid FCP_CMND length, it's not the CDB
authorSteffen Maier <maier@linux.ibm.com>
Thu, 8 Nov 2018 14:44:47 +0000 (15:44 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 15 Nov 2018 20:01:17 +0000 (15:01 -0500)
The CDB is just a part inside of FCP_CMND, see zfcp_fc_scsi_to_fcp().
While at it, fix the device driver reaction: adapter not LUN shutdown.

Signed-off-by: Steffen Maier <maier@linux.ibm.com>
Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/s390/scsi/zfcp_fsf.c

index c949c65ffc6a09a82073bdf23ffb7765808d72b2..0bdbc596da976bb14bd5890170c9dba5a4b0d413 100644 (file)
@@ -2090,11 +2090,8 @@ static void zfcp_fsf_fcp_handler_common(struct zfcp_fsf_req *req,
                break;
        case FSF_CMND_LENGTH_NOT_VALID:
                dev_err(&req->adapter->ccw_device->dev,
-                       "Incorrect CDB length %d, LUN 0x%016Lx on "
-                       "port 0x%016Lx closed\n",
-                       req->qtcb->bottom.io.fcp_cmnd_length,
-                       (unsigned long long)zfcp_scsi_dev_lun(sdev),
-                       (unsigned long long)zfcp_sdev->port->wwpn);
+                       "Incorrect FCP_CMND length %d, FCP device closed\n",
+                       req->qtcb->bottom.io.fcp_cmnd_length);
                zfcp_erp_adapter_shutdown(req->adapter, 0, "fssfch4");
                req->status |= ZFCP_STATUS_FSFREQ_ERROR;
                break;