]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
brcmfmac: check return value of driver_for_each_device()
authorZhang Changzhong <zhangchangzhong@huawei.com>
Sat, 19 Sep 2020 02:06:31 +0000 (10:06 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 24 Sep 2020 15:47:55 +0000 (18:47 +0300)
Fixes the following W=1 kernel build warning(s):

drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning:
 variable 'ret' set but not used [-Wunused-but-set-variable]
  1576 |  int ret;
       |      ^~~

driver_for_each_device() has been declared with __must_check, so the
return value should be checked.

Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/1600481191-14250-1-git-send-email-zhangchangzhong@huawei.com
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c

index ac5463838fcfbcc7d528459e2eedabf3def1ee6e..6f67fefe4b58540e78721ad98aabbb168c407eb8 100644 (file)
@@ -1578,6 +1578,9 @@ void brcmf_usb_exit(void)
        brcmf_dbg(USB, "Enter\n");
        ret = driver_for_each_device(drv, NULL, NULL,
                                     brcmf_usb_reset_device);
+       if (ret)
+               brcmf_err("failed to reset all usb devices %d\n", ret);
+
        usb_deregister(&brcmf_usbdrvr);
 }