]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
cifs: Fix bug when checking error condition in cifs_rename_pending_delete()
authorSachin Prabhu <sprabhu@redhat.com>
Tue, 5 Mar 2013 19:25:55 +0000 (19:25 +0000)
committerSteve French <sfrench@us.ibm.com>
Thu, 7 Mar 2013 00:28:35 +0000 (18:28 -0600)
Fix check for error condition after setting attributes with
CIFSSMBSetFileInfo().

Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Pavel Shilovsky <piastry@etersoft.ru>
Signed-off-by: Steve French <sfrench@us.ibm.com>
fs/cifs/inode.c

index 83f2606c76d00f090ec6a5b8e550a102de3fadbc..e7ae45cd94ef896bdd3ad9d375d90b5dc8c835f8 100644 (file)
@@ -1023,7 +1023,7 @@ cifs_rename_pending_delete(const char *full_path, struct dentry *dentry,
                                        current->tgid);
                /* although we would like to mark the file hidden
                   if that fails we will still try to rename it */
-               if (rc != 0)
+               if (!rc)
                        cifsInode->cifsAttrs = dosattr;
                else
                        dosattr = origattr; /* since not able to change them */