]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
iwlwifi: BA scd_flow not match condition detected
authorWey-Yi Guy <wey-yi.w.guy@intel.com>
Sat, 31 Jul 2010 15:34:11 +0000 (08:34 -0700)
committerJohn W. Linville <linville@tuxdriver.com>
Wed, 4 Aug 2010 19:27:37 +0000 (15:27 -0400)
It is a uCode bug which cause the tx queue id not match scd_flow
in compressed block ack frame, and it need to be addressed in uCode.
Currently, driver will log the information when it happen.

Since it is possible happen very often and we do not want to fill the syslog,
so don't enable the logging by default.

Signed-off-by: Wey-Yi Guy <wey-yi.w.guy@intel.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/iwlwifi/iwl-agn-tx.c

index 55a1b31fd09ae058bf805583d508715ab6a12d09..ecb953f28068808010eb1a1065612afe90899bf9 100644 (file)
@@ -1331,7 +1331,14 @@ void iwlagn_rx_reply_compressed_ba(struct iwl_priv *priv,
        tid = ba_resp->tid;
        agg = &priv->stations[sta_id].tid[tid].agg;
        if (unlikely(agg->txq_id != scd_flow)) {
-               IWL_ERR(priv, "BA scd_flow %d does not match txq_id %d\n",
+               /*
+                * FIXME: this is a uCode bug which need to be addressed,
+                * log the information and return for now!
+                * since it is possible happen very often and in order
+                * not to fill the syslog, don't enable the logging by default
+                */
+               IWL_DEBUG_TX_REPLY(priv,
+                       "BA scd_flow %d does not match txq_id %d\n",
                        scd_flow, agg->txq_id);
                return;
        }