]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
ARM: OMAP: Use kcalloc() in omap_system_dma_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 3 Oct 2017 19:07:33 +0000 (21:07 +0200)
committerTony Lindgren <tony@atomide.com>
Wed, 11 Oct 2017 18:13:15 +0000 (11:13 -0700)
* A multiplication for the size determination of a memory allocation
  indicated that an array data structure should be processed.
  Thus use the corresponding function "kcalloc".

  This issue was detected by using the Coccinelle software.

* Replace the specification of a data type by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Tony Lindgren <tony@atomide.com>
arch/arm/plat-omap/dma.c

index 409e4ecaebe920654918fe40be1c30f981445966..d4012d6c0dcb22deb2452857041483a99264bf4d 100644 (file)
@@ -1321,8 +1321,9 @@ static int omap_system_dma_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        if (dma_omap2plus()) {
-               dma_linked_lch = kzalloc(sizeof(struct dma_link_info) *
-                                               dma_lch_count, GFP_KERNEL);
+               dma_linked_lch = kcalloc(dma_lch_count,
+                                        sizeof(*dma_linked_lch),
+                                        GFP_KERNEL);
                if (!dma_linked_lch) {
                        ret = -ENOMEM;
                        goto exit_dma_lch_fail;