]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
mlxsw: core: Enable devlink reload only on probe
authorJiri Pirko <jiri@mellanox.com>
Sun, 10 Nov 2019 15:31:23 +0000 (16:31 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 12 Nov 2019 05:36:37 +0000 (21:36 -0800)
Call devlink enable only during probe time and avoid deadlock
during reload.

Reported-by: Shalom Toledo <shalomt@mellanox.com>
Fixes: 5a508a254bed ("devlink: disallow reload operation during device cleanup")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Tested-by: Shalom Toledo <shalomt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/core.c

index 20e9dc46cacd9a044b7083e9a2a7177387625880..0a0884d86d44d247985dac68058c0344db81780a 100644 (file)
@@ -1186,10 +1186,11 @@ __mlxsw_core_bus_device_register(const struct mlxsw_bus_info *mlxsw_bus_info,
        if (err)
                goto err_thermal_init;
 
-       if (mlxsw_driver->params_register) {
+       if (mlxsw_driver->params_register)
                devlink_params_publish(devlink);
+
+       if (!reload)
                devlink_reload_enable(devlink);
-       }
 
        return 0;