]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commitdiff
net/mlx5: Remove empty QP and CQ events handlers
authorLeon Romanovsky <leonro@mellanox.com>
Mon, 6 Apr 2020 05:40:52 +0000 (08:40 +0300)
committerLeon Romanovsky <leonro@mellanox.com>
Sun, 19 Apr 2020 12:53:18 +0000 (15:53 +0300)
The QP and CQ events functions do nothing except printing some debug
messages. There is nothing to do with this knowledge and such events,
so remove them.

Reviewed-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.c
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c

index 7c3e7232852e62fc967681a49078b2b30a904291..1d49894399af6fabd36463b419c467dc33f9bc68 100644 (file)
@@ -362,23 +362,6 @@ static void mlx5_fpga_conn_arm_cq(struct mlx5_fpga_conn *conn)
                    conn->fdev->conn_res.uar->map, conn->cq.wq.cc);
 }
 
-static void mlx5_fpga_conn_cq_event(struct mlx5_core_cq *mcq,
-                                   enum mlx5_event event)
-{
-       struct mlx5_fpga_conn *conn;
-
-       conn = container_of(mcq, struct mlx5_fpga_conn, cq.mcq);
-       mlx5_fpga_warn(conn->fdev, "CQ event %u on CQ #%u\n", event, mcq->cqn);
-}
-
-static void mlx5_fpga_conn_event(struct mlx5_core_qp *mqp, int event)
-{
-       struct mlx5_fpga_conn *conn;
-
-       conn = container_of(mqp, struct mlx5_fpga_conn, qp.mqp);
-       mlx5_fpga_warn(conn->fdev, "QP event %u on QP #%u\n", event, mqp->qpn);
-}
-
 static inline void mlx5_fpga_conn_cqes(struct mlx5_fpga_conn *conn,
                                       unsigned int budget)
 {
@@ -493,7 +476,6 @@ static int mlx5_fpga_conn_create_cq(struct mlx5_fpga_conn *conn, int cq_size)
        *conn->cq.mcq.arm_db    = 0;
        conn->cq.mcq.vector     = 0;
        conn->cq.mcq.comp       = mlx5_fpga_conn_cq_complete;
-       conn->cq.mcq.event      = mlx5_fpga_conn_cq_event;
        conn->cq.mcq.irqn       = irqn;
        conn->cq.mcq.uar        = fdev->conn_res.uar;
        tasklet_init(&conn->cq.tasklet, mlx5_fpga_conn_cq_tasklet,
@@ -607,7 +589,6 @@ static int mlx5_fpga_conn_create_qp(struct mlx5_fpga_conn *conn,
                goto err_sq_bufs;
 
        conn->qp.mqp.qpn = MLX5_GET(create_qp_out, out, qpn);
-       conn->qp.mqp.event = mlx5_fpga_conn_event;
        mlx5_fpga_dbg(fdev, "Created QP #0x%x\n", conn->qp.mqp.qpn);
 
        goto out;
index 88bc94a8b8f1c29f332d897348549abb34c6cb64..690e4181db4ca0a764d8c480ec16da6d4add33e8 100644 (file)
@@ -100,11 +100,6 @@ static int dr_poll_cq(struct mlx5dr_cq *dr_cq, int ne)
        return err == CQ_POLL_ERR ? err : npolled;
 }
 
-static void dr_qp_event(struct mlx5_core_qp *mqp, int event)
-{
-       pr_info("DR QP event %u on QP #%u\n", event, mqp->qpn);
-}
-
 static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev,
                                         struct dr_qp_init_attr *attr)
 {
@@ -187,7 +182,6 @@ static struct mlx5dr_qp *dr_create_rc_qp(struct mlx5_core_dev *mdev,
        kfree(in);
        if (err)
                goto err_in;
-       dr_qp->mqp.event = dr_qp_event;
        dr_qp->uar = attr->uar;
 
        return dr_qp;
@@ -695,12 +689,6 @@ static int dr_prepare_qp_to_rts(struct mlx5dr_domain *dmn)
        return 0;
 }
 
-static void dr_cq_event(struct mlx5_core_cq *mcq,
-                       enum mlx5_event event)
-{
-       pr_info("CQ event %u on CQ #%u\n", event, mcq->cqn);
-}
-
 static struct mlx5dr_cq *dr_create_cq(struct mlx5_core_dev *mdev,
                                      struct mlx5_uars_page *uar,
                                      size_t ncqe)
@@ -761,8 +749,6 @@ static struct mlx5dr_cq *dr_create_cq(struct mlx5_core_dev *mdev,
        pas = (__be64 *)MLX5_ADDR_OF(create_cq_in, in, pas);
        mlx5_fill_page_frag_array(&cq->wq_ctrl.buf, pas);
 
-       cq->mcq.event = dr_cq_event;
-
        err = mlx5_core_create_cq(mdev, &cq->mcq, in, inlen, out, sizeof(out));
        kvfree(in);