]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
tracing: Remove redundant reset per-CPU buff in irqsoff tracer
authorDmitry Safonov <0x7f454c46@gmail.com>
Mon, 19 Oct 2015 18:10:26 +0000 (21:10 +0300)
committerSteven Rostedt <rostedt@goodmis.org>
Fri, 18 Mar 2016 20:39:11 +0000 (16:39 -0400)
  There is no reason to do it twice: from commit b6f11df26fdc28
("trace: Call tracing_reset_online_cpus before tracer->init()")
resetting of per-CPU buffers done before tracer->init() call.

tracer->init() calls {irqs,preempt,preemptirqs}off_tracer_init() and it
calls __irqsoff_tracer_init(), which resets per-CPU ringbuffer second
time.
It's slowpath, but anyway.

Link: http://lkml.kernel.org/r/1445278226-16187-1-git-send-email-0x7f454c46@gmail.com
Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
kernel/trace/trace_irqsoff.c

index be3222b7d72ee5cdf280092035f56eb2403b23ce..03cdff84d026a74b0daf9e6c5ba02665752bf806 100644 (file)
@@ -626,7 +626,6 @@ static int __irqsoff_tracer_init(struct trace_array *tr)
        irqsoff_trace = tr;
        /* make sure that the tracer is visible */
        smp_wmb();
-       tracing_reset_online_cpus(&tr->trace_buffer);
 
        ftrace_init_array_ops(tr, irqsoff_tracer_call);