]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commitdiff
staging: lustre: libcfs: use break in switch options for libcfs_ioctl_handle
authorLiang Zhen <liang.zhen@intel.com>
Tue, 22 Mar 2016 23:03:49 +0000 (19:03 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
Instead of just returning for each switch condition use a break.

Signed-off-by: Liang Zhen <liang.zhen@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5435
Reviewed-on: http://review.whamcloud.com/11313
Reviewed-by: Bobi Jam <bobijam@gmail.com>
Reviewed-by: Johann Lombardi <johann.lombardi@intel.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lnet/libcfs/module.c

index f9f9d59052f81330d9ddd6c3a81b23f6e8e10d27..3fe2810640678abe16683223aef73826ff3fe334 100644 (file)
@@ -116,7 +116,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
                               void __user *arg, struct libcfs_ioctl_hdr *hdr)
 {
        struct libcfs_ioctl_data *data = NULL;
-       int err = -EINVAL;
+       int err = 0;
 
        /*
         * The libcfs_ioctl_data_adjust() function performs adjustment
@@ -134,7 +134,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
        switch (cmd) {
        case IOC_LIBCFS_CLEAR_DEBUG:
                libcfs_debug_clear_buffer();
-               return 0;
+               break;
        /*
         * case IOC_LIBCFS_PANIC:
         * Handled in arch/cfs_module.c
@@ -144,7 +144,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
                    data->ioc_inlbuf1[data->ioc_inllen1 - 1] != '\0')
                        return -EINVAL;
                libcfs_debug_mark_buffer(data->ioc_inlbuf1);
-               return 0;
+               break;
 
        default: {
                struct libcfs_ioctl_handler *hand;
@@ -161,8 +161,7 @@ static int libcfs_ioctl_handle(struct cfs_psdev_file *pfile, unsigned long cmd,
                        }
                }
                up_read(&ioctl_list_sem);
-               break;
-       }
+               break; }
        }
 
        return err;