]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
net: phy: dp83867: Fix various styling and space issues
authorDan Murphy <dmurphy@ti.com>
Thu, 3 Sep 2020 19:51:12 +0000 (14:51 -0500)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Sep 2020 23:51:07 +0000 (16:51 -0700)
Fix spacing issues reported for misaligned switch..case and extra new
lines.

Also updated the file header to comply with networking commet style.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Dan Murphy <dmurphy@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/dp83867.c

index f3c04981b8da67846eb9c0e5b20208741aecd3cc..ca26ccc6dfa44b291f25740a6b50087178fc7994 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/*
- * Driver for the Texas Instruments DP83867 PHY
+/* Driver for the Texas Instruments DP83867 PHY
  *
  * Copyright (C) 2015 Texas Instruments Inc.
  */
 #define DP83867_RGMII_RX_CLK_DELAY_SHIFT       0
 #define DP83867_RGMII_RX_CLK_DELAY_INV (DP83867_RGMII_RX_CLK_DELAY_MAX + 1)
 
-
 /* IO_MUX_CFG bits */
 #define DP83867_IO_MUX_CFG_IO_IMPEDANCE_MASK   0x1f
 #define DP83867_IO_MUX_CFG_IO_IMPEDANCE_MAX    0x0
@@ -384,22 +382,22 @@ static int dp83867_set_downshift(struct phy_device *phydev, u8 cnt)
                                      DP83867_DOWNSHIFT_EN);
 
        switch (cnt) {
-               case DP83867_DOWNSHIFT_1_COUNT:
-                       count = DP83867_DOWNSHIFT_1_COUNT_VAL;
-                       break;
-               case DP83867_DOWNSHIFT_2_COUNT:
-                       count = DP83867_DOWNSHIFT_2_COUNT_VAL;
-                       break;
-               case DP83867_DOWNSHIFT_4_COUNT:
-                       count = DP83867_DOWNSHIFT_4_COUNT_VAL;
-                       break;
-               case DP83867_DOWNSHIFT_8_COUNT:
-                       count = DP83867_DOWNSHIFT_8_COUNT_VAL;
-                       break;
-               default:
-                       phydev_err(phydev,
-                                  "Downshift count must be 1, 2, 4 or 8\n");
-                       return -EINVAL;
+       case DP83867_DOWNSHIFT_1_COUNT:
+               count = DP83867_DOWNSHIFT_1_COUNT_VAL;
+               break;
+       case DP83867_DOWNSHIFT_2_COUNT:
+               count = DP83867_DOWNSHIFT_2_COUNT_VAL;
+               break;
+       case DP83867_DOWNSHIFT_4_COUNT:
+               count = DP83867_DOWNSHIFT_4_COUNT_VAL;
+               break;
+       case DP83867_DOWNSHIFT_8_COUNT:
+               count = DP83867_DOWNSHIFT_8_COUNT_VAL;
+               break;
+       default:
+               phydev_err(phydev,
+                          "Downshift count must be 1, 2, 4 or 8\n");
+               return -EINVAL;
        }
 
        val = DP83867_DOWNSHIFT_EN;
@@ -411,7 +409,7 @@ static int dp83867_set_downshift(struct phy_device *phydev, u8 cnt)
 }
 
 static int dp83867_get_tunable(struct phy_device *phydev,
-                               struct ethtool_tunable *tuna, void *data)
+                              struct ethtool_tunable *tuna, void *data)
 {
        switch (tuna->id) {
        case ETHTOOL_PHY_DOWNSHIFT:
@@ -422,7 +420,7 @@ static int dp83867_get_tunable(struct phy_device *phydev,
 }
 
 static int dp83867_set_tunable(struct phy_device *phydev,
-                               struct ethtool_tunable *tuna, const void *data)
+                              struct ethtool_tunable *tuna, const void *data)
 {
        switch (tuna->id) {
        case ETHTOOL_PHY_DOWNSHIFT:
@@ -524,11 +522,10 @@ static int dp83867_of_init(struct phy_device *phydev)
                dp83867->io_impedance = -1; /* leave at default */
 
        dp83867->rxctrl_strap_quirk = of_property_read_bool(of_node,
-                                       "ti,dp83867-rxctrl-strap-quirk");
+                                                           "ti,dp83867-rxctrl-strap-quirk");
 
        dp83867->sgmii_ref_clk_en = of_property_read_bool(of_node,
-                                       "ti,sgmii-ref-clock-output-enable");
-
+                                                         "ti,sgmii-ref-clock-output-enable");
 
        dp83867->rx_id_delay = DP83867_RGMII_RX_CLK_DELAY_INV;
        ret = of_property_read_u32(of_node, "ti,rx-internal-delay",