]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
samples: bpf: Fix lwt_len_hist reusing previous BPF map
authorDaniel T. Lee <danieltimlee@gmail.com>
Tue, 24 Nov 2020 09:03:09 +0000 (09:03 +0000)
committerKleber Sacilotto de Souza <kleber.souza@canonical.com>
Wed, 20 Jan 2021 13:25:49 +0000 (14:25 +0100)
BugLink: https://bugs.launchpad.net/bugs/1910822
[ Upstream commit 0afe0a998c40085a6342e1aeb4c510cccba46caf ]

Currently, lwt_len_hist's map lwt_len_hist_map is uses pinning, and the
map isn't cleared on test end. This leds to reuse of that map for
each test, which prevents the results of the test from being accurate.

This commit fixes the problem by removing of pinned map from bpffs.
Also, this commit add the executable permission to shell script
files.

Fixes: f74599f7c5309 ("bpf: Add tests and samples for LWT-BPF")
Signed-off-by: Daniel T. Lee <danieltimlee@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Link: https://lore.kernel.org/bpf/20201124090310.24374-7-danieltimlee@gmail.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kelsey Skunberg <kelsey.skunberg@canonical.com>
samples/bpf/lwt_len_hist.sh [changed mode: 0644->0755]
samples/bpf/test_lwt_bpf.sh [changed mode: 0644->0755]

old mode 100644 (file)
new mode 100755 (executable)
index 090b96e..0eda975
@@ -8,6 +8,8 @@ VETH1=tst_lwt1b
 TRACE_ROOT=/sys/kernel/debug/tracing
 
 function cleanup {
+       # To reset saved histogram, remove pinned map
+       rm /sys/fs/bpf/tc/globals/lwt_len_hist_map
        ip route del 192.168.253.2/32 dev $VETH0 2> /dev/null
        ip link del $VETH0 2> /dev/null
        ip link del $VETH1 2> /dev/null
old mode 100644 (file)
new mode 100755 (executable)