]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/msm/dp: use dp_ctrl_off_link_stream during PHY compliance test run
authorKuogee Hsieh <khsieh@codeaurora.org>
Tue, 13 Jul 2021 15:54:01 +0000 (08:54 -0700)
committerRob Clark <robdclark@chromium.org>
Tue, 27 Jul 2021 15:14:56 +0000 (08:14 -0700)
DP cable should always connect to DPU during the entire PHY compliance
testing run. Since DP PHY compliance test is executed at irq_hpd event
context, dp_ctrl_off_link_stream() should be used instead of dp_ctrl_off().
dp_ctrl_off() is used for unplug event which is triggered when DP cable is
dis connected.

Changes in V2:
-- add fixes statement

Fixes: f21c8a276c2d ("drm/msm/dp: handle irq_hpd with sink_count = 0 correctly")
Signed-off-by: Kuogee Hsieh <khsieh@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/1626191647-13901-2-git-send-email-khsieh@codeaurora.org
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dp/dp_ctrl.c

index ee221d835fa0b97e73cf7ce7e5d85980a5e8a9b1..eaddfd7398850f501571e6dedff37e5d3496c83b 100644 (file)
@@ -1526,7 +1526,7 @@ static int dp_ctrl_process_phy_test_request(struct dp_ctrl_private *ctrl)
         * running. Add the global reset just before disabling the
         * link clocks and core clocks.
         */
-       ret = dp_ctrl_off(&ctrl->dp_ctrl);
+       ret = dp_ctrl_off_link_stream(&ctrl->dp_ctrl);
        if (ret) {
                DRM_ERROR("failed to disable DP controller\n");
                return ret;