]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commitdiff
net: hns3: Remove print messages for error packet
authorJian Shen <shenjian15@huawei.com>
Fri, 21 Sep 2018 15:41:45 +0000 (16:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 22 Sep 2018 02:29:32 +0000 (19:29 -0700)
There are already multiple types packets statistics for error packets,
it's unnecessary to print them, which may affect the rx performance if
print too many.

Signed-off-by: Jian Shen <shenjian15@huawei.com>
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Salil Mehta <salil.mehta@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 8b637077642d71ed6817b6ac7844118d5ad8c482..5a4773a9b4a57ce97f7f8d10fd6e355c7e7e6d46 100644 (file)
@@ -2149,7 +2149,6 @@ static void hns3_rx_checksum(struct hns3_enet_ring *ring, struct sk_buff *skb,
                     hnae3_get_bit(l234info, HNS3_RXD_L4E_B) ||
                     hnae3_get_bit(l234info, HNS3_RXD_OL3E_B) ||
                     hnae3_get_bit(l234info, HNS3_RXD_OL4E_B))) {
-               netdev_err(netdev, "L3/L4 error pkt\n");
                u64_stats_update_begin(&ring->syncp);
                ring->stats.l3l4_csum_err++;
                u64_stats_update_end(&ring->syncp);
@@ -2328,8 +2327,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring,
        }
 
        if (unlikely(!hnae3_get_bit(bd_base_info, HNS3_RXD_VLD_B))) {
-               netdev_err(netdev, "no valid bd,%016llx,%016llx\n",
-                          ((u64 *)desc)[0], ((u64 *)desc)[1]);
                u64_stats_update_begin(&ring->syncp);
                ring->stats.non_vld_descs++;
                u64_stats_update_end(&ring->syncp);
@@ -2340,7 +2337,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring,
 
        if (unlikely((!desc->rx.pkt_len) ||
                     hnae3_get_bit(l234info, HNS3_RXD_TRUNCAT_B))) {
-               netdev_err(netdev, "truncated pkt\n");
                u64_stats_update_begin(&ring->syncp);
                ring->stats.err_pkt_len++;
                u64_stats_update_end(&ring->syncp);
@@ -2350,7 +2346,6 @@ static int hns3_handle_rx_bd(struct hns3_enet_ring *ring,
        }
 
        if (unlikely(hnae3_get_bit(l234info, HNS3_RXD_L2E_B))) {
-               netdev_err(netdev, "L2 error pkt\n");
                u64_stats_update_begin(&ring->syncp);
                ring->stats.l2_err++;
                u64_stats_update_end(&ring->syncp);