]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
drm/i915/lpe: Mark LPE audio runtime pm as "no callbacks"
authorChris Wilson <chris@chris-wilson.co.uk>
Thu, 2 Aug 2018 14:04:16 +0000 (15:04 +0100)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Mon, 6 Aug 2018 18:18:09 +0000 (11:18 -0700)
The LPE audio is a child device of i915, it is powered up and down
alongside the igfx and presents no independent runtime interface. This
aptly fulfils the description of a "No-Callback" Device, so mark it
thus.

Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
Testcase: igt/pm_rpm/basic-pci-d3-state
Testcase: igt/pm_rpm/basic-rte
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180802140416.6062-1-chris@chris-wilson.co.uk
(cherry picked from commit 46e831abe864a6b59fa3de253a681c0f2ee1bf2f)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
drivers/gpu/drm/i915/intel_lpe_audio.c

index 6269750e2b547c3db8969e54c6ab03116a1e112f..430732720e656b0468b0914d9d1e528ecc3cf5f8 100644 (file)
@@ -126,9 +126,7 @@ lpe_audio_platdev_create(struct drm_i915_private *dev_priv)
                return platdev;
        }
 
-       pm_runtime_forbid(&platdev->dev);
-       pm_runtime_set_active(&platdev->dev);
-       pm_runtime_enable(&platdev->dev);
+       pm_runtime_no_callbacks(&platdev->dev);
 
        return platdev;
 }