]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
drm/mipi: use dcs write for mipi_dsi_dcs_set_tear_scanline
authorEmil Velikov <emil.velikov@collabora.com>
Tue, 5 May 2020 16:03:29 +0000 (17:03 +0100)
committerSam Ravnborg <sam@ravnborg.org>
Mon, 29 Jun 2020 07:45:15 +0000 (09:45 +0200)
The helper uses the MIPI_DCS_SET_TEAR_SCANLINE, although it's currently
using the generic write. This does not look right.

Perhaps some platforms don't distinguish between the two writers?

Cc: Robert Chiras <robert.chiras@nxp.com>
Cc: Vinay Simha BN <simhavcs@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Thierry Reding <treding@nvidia.com>
Fixes: e83950816367 ("drm/dsi: Implement set tear scanline")
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200505160329.2976059-3-emil.l.velikov@gmail.com
drivers/gpu/drm/drm_mipi_dsi.c

index b96d5b4629d7bb94100ae8609f3094ca6fa1d2c7..07102d8da58fdd8c0a4b36cd1157ced6ed10d8c2 100644 (file)
@@ -1082,11 +1082,11 @@ EXPORT_SYMBOL(mipi_dsi_dcs_set_pixel_format);
  */
 int mipi_dsi_dcs_set_tear_scanline(struct mipi_dsi_device *dsi, u16 scanline)
 {
-       u8 payload[3] = { MIPI_DCS_SET_TEAR_SCANLINE, scanline >> 8,
-                         scanline & 0xff };
+       u8 payload[2] = { scanline >> 8, scanline & 0xff };
        ssize_t err;
 
-       err = mipi_dsi_generic_write(dsi, payload, sizeof(payload));
+       err = mipi_dsi_dcs_write(dsi, MIPI_DCS_SET_TEAR_SCANLINE, payload,
+                                sizeof(payload));
        if (err < 0)
                return err;