]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
can: esd_usb2: cancel urb on -EPIPE and -EPROTO
authorMartin Kelly <mkelly@xevo.com>
Tue, 5 Dec 2017 19:15:48 +0000 (11:15 -0800)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 8 Dec 2017 09:45:11 +0000 (10:45 +0100)
In mcba_usb, we have observed that when you unplug the device, the driver will
endlessly resubmit failing URBs, which can cause CPU stalls. This issue
is fixed in mcba_usb by catching the codes seen on device disconnect
(-EPIPE and -EPROTO).

This driver also resubmits in the case of -EPIPE and -EPROTO, so fix it
in the same way.

Signed-off-by: Martin Kelly <mkelly@xevo.com>
Cc: linux-stable <stable@vger.kernel.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/usb/esd_usb2.c

index 9fdb0f0bfa06a00a2ade5e74daef15798ab7d4a1..c6dcf93675c00585bd960f579988ea1c2d348d50 100644 (file)
@@ -393,6 +393,8 @@ static void esd_usb2_read_bulk_callback(struct urb *urb)
                break;
 
        case -ENOENT:
+       case -EPIPE:
+       case -EPROTO:
        case -ESHUTDOWN:
                return;