]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
soc: qcom: pdr: Fixup array type of get_domain_list_resp message
authorSibi Sankar <sibis@codeaurora.org>
Mon, 14 Sep 2020 14:58:07 +0000 (20:28 +0530)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Mon, 14 Sep 2020 23:53:29 +0000 (23:53 +0000)
The array type of get_domain_list_resp is incorrectly marked as NO_ARRAY.
Due to which the following error was observed when using pdr helpers with
the downstream proprietary pd-mapper. Fix this up by marking it as
VAR_LEN_ARRAY instead.

Err logs:
qmi_decode_struct_elem: Fault in decoding: dl(2), db(27), tl(160), i(1), el(1)
failed to decode incoming message
PDR: tms/servreg get domain list txn wait failed: -14
PDR: service lookup for tms/servreg failed: -14

Tested-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Fixes: fbe639b44a82 ("soc: qcom: Introduce Protection Domain Restart helpers")
Reported-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
Link: https://lore.kernel.org/r/20200914145807.1224-1-sibis@codeaurora.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
drivers/soc/qcom/pdr_internal.h

index 15b5002e4127b39a2c4c158813f8065d5445053f..ab9ae8cdfa54c104b362c9f7d91f8dc70465bb6d 100644 (file)
@@ -185,7 +185,7 @@ struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {
                .data_type      = QMI_STRUCT,
                .elem_len       = SERVREG_DOMAIN_LIST_LENGTH,
                .elem_size      = sizeof(struct servreg_location_entry),
-               .array_type     = NO_ARRAY,
+               .array_type     = VAR_LEN_ARRAY,
                .tlv_type       = 0x12,
                .offset         = offsetof(struct servreg_get_domain_list_resp,
                                           domain_list),