]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commitdiff
tls: Correct length of scatterlist in tls_sw_sendpage
authorDave Watson <davejwatson@fb.com>
Fri, 19 Jan 2018 20:30:13 +0000 (12:30 -0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 22 Jan 2018 21:25:21 +0000 (16:25 -0500)
The scatterlist is reused by both sendmsg and sendfile.
If a sendmsg of smaller number of pages is followed by a sendfile
of larger number of pages, the scatterlist may be too short, resulting
in a crash in gcm_encrypt.

Add sg_unmark_end to make the list the correct length.

tls_sw_sendmsg already calls sg_unmark_end correctly when it allocates
memory in alloc_sg, or in zerocopy_from_iter.

Signed-off-by: Dave Watson <davejwatson@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_sw.c

index 61f394d369bf86d69c44b84950632cd5c3519905..0a9b72fbd761f9c69ba63f651d971c228a70b948 100644 (file)
@@ -577,6 +577,8 @@ alloc_payload:
                get_page(page);
                sg = ctx->sg_plaintext_data + ctx->sg_plaintext_num_elem;
                sg_set_page(sg, page, copy, offset);
+               sg_unmark_end(sg);
+
                ctx->sg_plaintext_num_elem++;
 
                sk_mem_charge(sk, copy);