]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commitdiff
btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s
authorJosef Bacik <josef@toxicpanda.com>
Fri, 12 Mar 2021 20:25:21 +0000 (15:25 -0500)
committerDavid Sterba <dsterba@suse.com>
Mon, 19 Apr 2021 15:25:21 +0000 (17:25 +0200)
A few BUG_ON()'s in replace_path are purely to keep us from making
logical mistakes, so replace them with ASSERT()'s.

Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/relocation.c

index 489097fbf9e2dff059bbb0ccd063b5af3d079005..62b6d3f1fbead0f5d5baa2de381c4151d3ae4cf7 100644 (file)
@@ -1211,8 +1211,8 @@ int replace_path(struct btrfs_trans_handle *trans, struct reloc_control *rc,
        int ret;
        int slot;
 
-       BUG_ON(src->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);
-       BUG_ON(dest->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);
+       ASSERT(src->root_key.objectid == BTRFS_TREE_RELOC_OBJECTID);
+       ASSERT(dest->root_key.objectid != BTRFS_TREE_RELOC_OBJECTID);
 
        last_snapshot = btrfs_root_last_snapshot(&src->root_item);
 again:
@@ -1243,7 +1243,7 @@ again:
        parent = eb;
        while (1) {
                level = btrfs_header_level(parent);
-               BUG_ON(level < lowest_level);
+               ASSERT(level >= lowest_level);
 
                ret = btrfs_bin_search(parent, &key, &slot);
                if (ret < 0)