]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commitdiff
staging: comedi: remove 'bi.subdevice < 0' check in do_bufinfo_ioctl()
authorGüngör Erseymen <gelurine@gmail.com>
Fri, 7 Jun 2013 18:29:50 +0000 (21:29 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2013 05:14:27 +0000 (22:14 -0700)
Type of variable 'bi' is struct comedi_bufinfo and 'subdevice' is
defined as unsigned, so there is no need to check if it is less then
zero.

Signed-off-by: Güngör Erseymen <gelurine@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c

index 986f1957268953d51f3429763294e87d6dd8aa40..c561a0eda92a6c6edddd2d095d3f1f23e39607e0 100644 (file)
@@ -913,7 +913,7 @@ static int do_bufinfo_ioctl(struct comedi_device *dev,
        if (copy_from_user(&bi, arg, sizeof(bi)))
                return -EFAULT;
 
-       if (bi.subdevice >= dev->n_subdevices || bi.subdevice < 0)
+       if (bi.subdevice >= dev->n_subdevices)
                return -EINVAL;
 
        s = &dev->subdevices[bi.subdevice];