Update VM SCSI controller type after OS selection in Wizard

This was done previously without any kind of user visible feedback, so users
would not know that they had a Virtio SCSI controller as default controller
for Linux VMs.

Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/www/manager6/qemu/CreateWizard.js b/www/manager6/qemu/CreateWizard.js
index 954b8ef0e6537e8a9204d70c05ac73c48dea0e75..c508bb7feae4e78b53350873efb9738cd5993d02 100644 (file)
--- a/www/manager6/qemu/CreateWizard.js
+++ b/www/manager6/qemu/CreateWizard.js
@@ -1,7 +1,6 @@
 Ext.define('PVE.qemu.CreateWizard', {
     extend: 'PVE.window.Wizard',
     alias: 'widget.pveQemuCreateWizard',
-    qemuScsiController: undefined,
 
     controller: {
 
@@ -167,10 +166,6 @@ Ext.define('PVE.qemu.CreateWizard', {
                        var nodename = kv.nodename;
                        delete kv.nodename;
 
-                       if (me.qemuScsiController && !kv.scsihw) {
-                           kv.scsihw = me.qemuScsiController;
-                       }
-
                        PVE.Utils.API2Request({
                            url: '/nodes/' + nodename + '/qemu',
                            waitMsgTarget: me,

diff --git a/www/manager6/qemu/OSDefaults.js b/www/manager6/qemu/OSDefaults.js
index d47b9d01fc3a2b89648f281c10c1548be8332ca9..d6f733a83bf7e08df65444c862216f7a60d961c2 100644 (file)
--- a/www/manager6/qemu/OSDefaults.js
+++ b/www/manager6/qemu/OSDefaults.js
@@ -66,7 +66,7 @@ Ext.define('PVE.qemu.OSDefaults', {
            pveOS: 'w2k',
            parent : 'generic',
            networkCard: 'rtl8139',
-           scsihw: 'lsi'
+           scsihw: ''
        });
        // https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes
        addOS({

diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index 1235ddfdce61fb827837d6b71099761c30dbbdf4..27b0c40cd9f814c7d98a10066dd9a6fc60041c57 100644 (file)
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -27,7 +27,7 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
 
            me.setWidget('pveBusSelector', targetValues.busType);
            me.setWidget('pveNetworkCardSelector', targetValues.networkCard);
-           me.setWizardHiddenValue('qemuScsiController', targetValues.scsihw);
+           me.setWidget('field[name=scsihw]', targetValues.scsihw);
        },
        setWidget: function(widget, newValue) {
            // changing a widget is safe only if ComponentQuery.query returns us
@@ -38,14 +38,6 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
            } else {
                throw 'non unique widget :' + widget + ' in Wizard';
            }
-       },
-       setWizardHiddenValue: function(property, newValue) {
-           var wizards = Ext.ComponentQuery.query('pveQemuCreateWizard ');
-           if (wizards.length === 1) {
-               wizards[0][property] = newValue;
-           } else {
-               throw 'non unique wizard, unable to set ' + property;
-           }
        }
     },