]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commitdiff
selftests/resctrl: Fix missing options "-n" and "-p"
authorFenghua Yu <fenghua.yu@intel.com>
Wed, 17 Mar 2021 02:22:40 +0000 (02:22 +0000)
committerStefan Bader <stefan.bader@canonical.com>
Wed, 19 May 2021 08:32:11 +0000 (10:32 +0200)
BugLink: https://bugs.launchpad.net/bugs/1928857
[ Upstream commit d7af3d0d515cbdf63b6c3398a3c15ecb1bc2bd38 ]

resctrl test suite accepts command line arguments (like -b, -t, -n and -p)
as documented in the help. But passing -n and -p throws an invalid option
error. This happens because -n and -p are missing in the list of
characters that getopt() recognizes as valid arguments. Hence, they are
treated as invalid options.

Fix this by adding them to the list of characters that getopt() recognizes
as valid arguments. Please note that the main() function already has the
logic to deal with the values passed as part of these arguments and hence
no changes are needed there.

Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
tools/testing/selftests/resctrl/resctrl_tests.c

index 4b109a59f72da2e96e9d2a5a3f2bfb47228687b9..ac2269610aa9d7fdbd82b7b14b49545b1c996556 100644 (file)
@@ -73,7 +73,7 @@ int main(int argc, char **argv)
                }
        }
 
-       while ((c = getopt(argc_new, argv, "ht:b:")) != -1) {
+       while ((c = getopt(argc_new, argv, "ht:b:n:p:")) != -1) {
                char *token;
 
                switch (c) {