]> git.proxmox.com Git - mirror_qemu.git/commitdiff
vnc: fix a qio-channel leak
authorMarc-André Lureau <marcandre.lureau@redhat.com>
Fri, 17 Mar 2017 09:28:02 +0000 (13:28 +0400)
committerGerd Hoffmann <kraxel@redhat.com>
Mon, 20 Mar 2017 08:07:34 +0000 (09:07 +0100)
Spotted by ASAN.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20170317092802.17973-1-marcandre.lureau@redhat.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
ui/vnc.c

index 8bfb1e0685dde488223323174af4a69f92b36aee..6e93b883b544384d4374c43a3c788b541ee110f5 100644 (file)
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3677,6 +3677,7 @@ static int vnc_display_listen_addr(VncDisplay *vd,
         qio_channel_set_name(QIO_CHANNEL(sioc), name);
         if (qio_channel_socket_listen_sync(
                 sioc, rawaddrs[i], listenerr == NULL ? &listenerr : NULL) < 0) {
+            object_unref(OBJECT(sioc));
             continue;
         }
         listening = true;